-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-26482][K8S][TEST][FOLLOWUP] Fix compile failure #23527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @ifilonenko , @vanzin , @HeartSaVioR |
|
Kubernetes integration test starting |
|
Test build #101112 has finished for PR 23527 at commit
|
|
Kubernetes integration test status success |
|
I'm confused - how did this go in originally that breaks the build? |
|
Thank you for review, @felixcheung . It seems that K8S integration test triggers only when the PR title has |
|
Merged to master. |
That seems to be a problem. |
|
looks like integration test is not in the module list https://github.com/apache/spark/blob/master/dev/sparktestsupport/modules.py#L542 so it doesn't get build unless the profile |
|
I think we need it added to module and then only "execute the test" when the profile is set |
|
Thanks @dongjoon-hyun for fixing missing spot! Looks like I confused between SparkConf and SparkAppConf. I couldn't run all tests in local (since it takes hours) but was trying to ensure compilation passes, so ran below command: Maybe I needed to add |
## What changes were proposed in this pull request? This fixes K8S integration test compilation failure introduced by apache#23423 . ```scala $ build/sbt -Pkubernetes-integration-tests test:package ... [error] /Users/dongjoon/APACHE/spark/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesTestComponents.scala:71: type mismatch; [error] found : org.apache.spark.internal.config.OptionalConfigEntry[Boolean] [error] required: String [error] .set(IS_TESTING, false) [error] ^ [error] /Users/dongjoon/APACHE/spark/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesTestComponents.scala:71: type mismatch; [error] found : Boolean(false) [error] required: String [error] .set(IS_TESTING, false) [error] ^ [error] two errors found ``` ## How was this patch tested? Pass the K8S integration test. Closes apache#23527 from dongjoon-hyun/SPARK-26482. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
What changes were proposed in this pull request?
This fixes K8S integration test compilation failure introduced by #23423 .
How was this patch tested?
Pass the K8S integration test.