[SPARK-26156][WebUI] Revise summary section of stage page #23125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
srowen
reviewed
Nov 23, 2018
| localityNamesAndCounts.sorted.mkString("; ") | ||
| } | ||
|
|
||
| private def jobURL(request: HttpServletRequest, jobId: Int): String = |
Member
There was a problem hiding this comment.
It all looks fine except I don't see a lot of value in moving this into a method that's used once. It just moves the logic to a separate part of the file.
Member
Author
There was a problem hiding this comment.
Make sense. I have updated the code.
|
Test build #99214 has finished for PR 23125 at commit
|
|
Test build #99216 has finished for PR 23125 at commit
|
Member
|
Merged to master |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? In the summary section of stage page:  1. the following metrics names can be revised: Output => Output Size / Records Shuffle Read: => Shuffle Read Size / Records Shuffle Write => Shuffle Write Size / Records After changes, the names are more clear, and consistent with the other names in the same page. 2. The associated job id URL should not contain the 3 tails spaces. Reduce the number of spaces to one, and exclude the space from link. This is consistent with SQL execution page. ## How was this patch tested? Manual check:  Closes apache#23125 from gengliangwang/reviseStagePage. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the summary section of stage page:
Output => Output Size / Records
Shuffle Read: => Shuffle Read Size / Records
Shuffle Write => Shuffle Write Size / Records
After changes, the names are more clear, and consistent with the other names in the same page.
How was this patch tested?
Manual check:
