[SPARK-26141] Enable custom metrics implementation in shuffle write #23106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxin
changed the title
|
Test build #99130 has finished for PR 23106 at commit
|
squito
approved these changes
Nov 26, 2018
Contributor
squito
left a comment
squito
left a comment
There was a problem hiding this comment.
lgtm, just a minor comment
| taskContext.taskMetrics().incDiskBytesSpilled(writeMetricsToUse.bytesWritten()); | ||
|
|
||
| // This is guaranteed to be a ShuffleWriteMetrics based on the if check in the beginning | ||
| // of this file. |
Contributor
There was a problem hiding this comment.
I found "beginning of this file" to be confusing, I thought you meant the beginning of ShuffleExternalSorter.java, not the spill file. maybe "beginning of this method"
also is the comment above this about SPARK-3577 out of date now that has been fixed?
|
Test build #99285 has finished for PR 23106 at commit
|
|
Test build #99298 has finished for PR 23106 at commit
|
Contributor
Author
|
Merging in master. Thanks @squito. |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? This patch defines an internal Spark interface for reporting shuffle metrics and uses that in shuffle reader. Before this patch, shuffle metrics is tied to a specific implementation (using a thread local temporary data structure and accumulators). After this patch, callers that define their own shuffle RDDs can create a custom metrics implementation. With this patch, we would be able to create a better metrics for the SQL layer, e.g. reporting shuffle metrics in the SQL UI, for each exchange operator. Note that I'm separating read side and write side implementations, as they are very different, to simplify code review. Write side change is at apache#23106 ## How was this patch tested? No behavior change expected, as it is a straightforward refactoring. Updated all existing test cases. Closes apache#23105 from rxin/SPARK-26140. Authored-by: Reynold Xin <[email protected]> Signed-off-by: gatorsmile <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? This is the write side counterpart to apache#23105 ## How was this patch tested? No behavior change expected, as it is a straightforward refactoring. Updated all existing test cases. Closes apache#23106 from rxin/SPARK-26141. Authored-by: Reynold Xin <[email protected]> Signed-off-by: Reynold Xin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is the write side counterpart to #23105
How was this patch tested?
No behavior change expected, as it is a straightforward refactoring. Updated all existing test cases.