Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Nov 19, 2018

What changes were proposed in this pull request?

Update many plugins we use to the latest version, especially MiMa, which entails excluding some new errors on old changes.

How was this patch tested?

N/A

@SparkQA
Copy link

SparkQA commented Nov 19, 2018

Test build #99001 has finished for PR 23087 at commit 2760338.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

pom.xml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyukjinKwon
Copy link
Member

Looks fine to me.

@srowen
Copy link
Member Author

srowen commented Nov 20, 2018

Will do. I'm going to update some SBT plugins too. Many we can't update because they kind of go hand-in-hand with SBT 1.x, and those versions in turn seem to go with Scala 2.12, so they may all have to happen together.

We can update MiMa to get some fixes, but they uncover some new errors on old code. I'm going to make a JIRA.

@srowen srowen changed the title [MINOR][BUILD] Update plugins to latest versions [SPARK-26124][BUILD] Update plugins to latest versions Nov 20, 2018
@SparkQA
Copy link

SparkQA commented Nov 20, 2018

Test build #99034 has finished for PR 23087 at commit 93cd718.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 20, 2018

Test build #99032 has finished for PR 23087 at commit 6a39012.

  • This patch passes all tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

reest this please

@viirya
Copy link
Member

viirya commented Nov 20, 2018

retest this please.

@srowen
Copy link
Member Author

srowen commented Nov 20, 2018

It's OK; it clearly does merge cleanly and tests pass. I have seen apparently spurious "does not merge cleanly" messages before and I assume it's because something else transient went wrong with a git command.

@SparkQA
Copy link

SparkQA commented Nov 20, 2018

Test build #99051 has finished for PR 23087 at commit 93cd718.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member Author

srowen commented Nov 21, 2018

Merged to master

@asfgit asfgit closed this in 4785105 Nov 21, 2018
@srowen srowen deleted the Plugins branch November 26, 2018 13:17
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?

Update many plugins we use to the latest version, especially MiMa, which entails excluding some new errors on old changes.

## How was this patch tested?

N/A

Closes apache#23087 from srowen/Plugins.

Authored-by: Sean Owen <[email protected]>
Signed-off-by: Sean Owen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants