[SPARK-26043][CORE] Make SparkHadoopUtil private to Spark #23066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CC @vanzin . I took the liberty of simplifying a few other bits of the file too. |
|
Test build #98949 has finished for PR 23066 at commit
|
|
Test build #4428 has finished for PR 23066 at commit
|
|
Test build #4431 has finished for PR 23066 at commit
|
Member
Author
|
Merged to master |
asfgit
pushed a commit
that referenced
this pull request
Nov 20, 2018
## What changes were proposed in this pull request? Make SparkHadoopUtil private to Spark ## How was this patch tested? Existing tests. Closes #23066 from srowen/SPARK-26043. Authored-by: Sean Owen <[email protected]> Signed-off-by: Sean Owen <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? Make SparkHadoopUtil private to Spark ## How was this patch tested? Existing tests. Closes apache#23066 from srowen/SPARK-26043. Authored-by: Sean Owen <[email protected]> Signed-off-by: Sean Owen <[email protected]>
|
@srowen Our app is using the SparkHadoopUtils.addCredentials API to do this before using a custom datasource of ours and are now facing breaking changes. I don't see this mentioned anywhere in a migration guide or release notes. |
Member
Author
|
The idea is that it was never meant for users (developer API) and wasn't easy to make stable. You can simply replicate its code in your code base; it's just a bit of helper code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make SparkHadoopUtil private to Spark
How was this patch tested?
Existing tests.