[SPARK-25160][SQL]Avro: remove sql configuration spark.sql.avro.outputTimestampType #22151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #94949 has finished for PR 22151 at commit
|
viirya
reviewed
Aug 20, 2018
| s"Avro type $avroStruct.") | ||
| } | ||
| val avroFields = avroStruct.getFields | ||
| assert(avroFields.size() == catalystStruct.length) |
Member
There was a problem hiding this comment.
Is this check redundant? Why remove it now?
Member
There was a problem hiding this comment.
I think he moved this condition above.
Member
There was a problem hiding this comment.
Ah, yea, strictly sounds unrelated tho.
viirya
reviewed
Aug 20, 2018
| } | ||
|
|
||
| test("Logical type: user specified schema") { | ||
| test("Logical type: user specified read schema") { |
Member
There was a problem hiding this comment.
nit: Logical type: user specified read schema with different timestamp types.
Member
|
LGTM |
Member
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR for supporting logical timestamp types #21935, a SQL configuration spark.sql.avro.outputTimestampType is added, so that user can specify the output timestamp precision they want.
With PR #21847, the output file can be written with user specified types.
So there is no need to have such trivial configuration. Otherwise to make it consistent we need to add configuration for all the Catalyst types that can be converted into different Avro types.
This PR also add a test case for user specified output schema with different timestamp types.
How was this patch tested?
Unit test