Skip to content

[SPARK-24529][Build][test-maven][follow-up] Add spotbugs 3.1.6 into maven build process #21994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kiszk wants to merge 1 commit into from
Closed

[SPARK-24529][Build][test-maven][follow-up] Add spotbugs 3.1.6 into maven build process #21994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2609,6 +2609,28 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
Copy link
Member

@gatorsmile gatorsmile Aug 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, after having this plugin, I were unable to perform parallel builds.

https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3

Copy link
Member

@gatorsmile gatorsmile Aug 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like this plug in is not thread safe.

Copy link
Member Author

@kiszk kiszk Aug 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I have not tried this with parallel build. Spotbugs looks non MT-safe

Copy link
Member

@gatorsmile gatorsmile Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding spotbugs slows down my local build a lot. Can we hold this?

Copy link
Member

@HyukjinKwon HyukjinKwon Aug 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, this slows down 16ish mins and that was my concern at the very first place. Currently, it only affects Maven build though. +1 for holding on for now.

Copy link
Member Author

@kiszk kiszk Aug 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me check the elapsed time on my environment. +1 for holding on for now.

<version>3.1.6</version>
<configuration>
<classFilesDirectory>${basedir}/target/scala-${scala.binary.version}/classes</classFilesDirectory>
<testClassFilesDirectory>${basedir}/target/scala-${scala.binary.version}/test-classes</testClassFilesDirectory>
<effort>Max</effort>
<threshold>Low</threshold>
<xmlOutput>true</xmlOutput>
<visitors>FindPuzzlers</visitors>
<fork>true</fork>
</configuration>
<executions>
<execution>
<goals>
<goal>check</goal>
</goals>
<phase>compile</phase>
</execution>
</executions>
</plugin>
</plugins>
</build>

Expand Down