Skip to content

[SPARK-24477][SPARK-24454][ML][PYTHON] Imports submodule in ml/__init__.py and add ImageSchema into __all__ #21483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 2 commits into from
Closed

[SPARK-24477][SPARK-24454][ML][PYTHON] Imports submodule in ml/__init__.py and add ImageSchema into __all__ #21483

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49323a6
Imports submodule in ml/__init__.py and add ImageSchema into __all__
HyukjinKwon Jun 2, 2018
bfcd3aa
Address comments
HyukjinKwon Jun 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion python/pyspark/ml/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,11 @@
"""
from pyspark.ml.base import Estimator, Model, Transformer, UnaryTransformer
from pyspark.ml.pipeline import Pipeline, PipelineModel
from pyspark.ml import classification, clustering, evaluation, feature, fpm, \
image, pipeline, recommendation, regression, stat, tuning, util

__all__ = ["Transformer", "UnaryTransformer", "Estimator", "Model", "Pipeline", "PipelineModel"]
__all__ = [
"Transformer", "UnaryTransformer", "Estimator", "Model", "Pipeline", "PipelineModel",
"base", "classification", "clustering", "evaluation", "feature", "fpm",
Copy link
Contributor

@mengxr mengxr Jun 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base shouldn't be imported by default

"image", "pipeline", "recommendation", "regression", "stat", "tuning", "util",
Copy link
Contributor

@mengxr mengxr Jun 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove pipeline from default imports and add linalg and param. Basically, import public modules listed here: https://spark.apache.org/docs/latest/api/python/index.html.

]
2 changes: 2 additions & 0 deletions python/pyspark/ml/image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
from pyspark.sql.types import Row, _create_row, _parse_datatype_json_string
from pyspark.sql import DataFrame, SparkSession

__all__ = ["ImageSchema"]


class _ImageSchema(object):
"""
Expand Down