Skip to content

[FIX] fix error message in sendMessageReliably #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mengxr wants to merge 1 commit into from
Closed

[FIX] fix error message in sendMessageReliably #2120

mengxr wants to merge 1 commit into from

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented Aug 25, 2014

@SparkQA
Copy link

SparkQA commented Aug 25, 2014

QA tests have started for PR 2120 at commit b14400c.

  • This patch merges cleanly.

@JoshRosen
Copy link
Contributor

JoshRosen commented Aug 25, 2014

LGTM; good catch. Isn't there a compiler warning for this sort of issue?

@rxin
Copy link
Contributor

rxin commented Aug 25, 2014

LGTM.

@SparkQA
Copy link

SparkQA commented Aug 25, 2014

QA tests have finished for PR 2120 at commit b14400c.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KMeansModel (val clusterCenters: Array[Vector]) extends Serializable

@mridulm
Copy link
Contributor

mridulm commented Aug 25, 2014

nice bug, something for me to watch out for, thx !

@JoshRosen
Copy link
Contributor

JoshRosen commented Aug 25, 2014

Merged into master and branch-1.1. Thanks!

@asfgit asfgit closed this in fd8ace2 Aug 25, 2014
asfgit pushed a commit that referenced this pull request Aug 25, 2014
@mengxr @JoshRosen
[FIX] fix error message in sendMessageReliably
d892062 
rxin

Author: Xiangrui Meng <[email protected]>

Closes #2120 from mengxr/sendMessageReliably and squashes the following commits:

b14400c [Xiangrui Meng] fix error message in sendMessageReliably

(cherry picked from commit fd8ace2)
Signed-off-by: Josh Rosen <[email protected]>
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@mengxr @conviva-zz
[FIX] fix error message in sendMessageReliably
030af13 
rxin

Author: Xiangrui Meng <[email protected]>

Closes apache#2120 from mengxr/sendMessageReliably and squashes the following commits:

b14400c [Xiangrui Meng] fix error message in sendMessageReliably
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mengxr @SparkQA @JoshRosen @rxin @mridulm