Skip to content

[SPARK-23826] [TEST] TestHiveSparkSession should set default session #20969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gatorsmile wants to merge 2 commits into from
Closed

[SPARK-23826] [TEST] TestHiveSparkSession should set default session #20969

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
228730b
fix.
gatorsmile Apr 3, 2018
f7e0b03
fix.
gatorsmile Apr 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,10 @@ private[hive] class TestHiveSparkSession(
private val loadTestTables: Boolean)
extends SparkSession(sc) with Logging { self =>

// TODO(SPARK-23826): TestHiveSparkSession should set default session the same way as
// TestSparkSession, but doing this the same way breaks many tests in the package. We need
// to investigate and find a different strategy.
// The base spark session does this in getOrCreate(), here we emulate that behavior for tests.
if (SparkSession.getDefaultSession.isEmpty) {
SparkSession.setDefaultSession(this)
}
Copy link
Member Author

@gatorsmile gatorsmile Apr 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed after we merge #20927


def this(sc: SparkContext, loadTestTables: Boolean) {
this(
Expand Down