Skip to content

[SPARK-2967][SQL] Follow-up: Also copy hash expressions in sort based shuffle fix. #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marmbrus wants to merge 1 commit into from
Closed

[SPARK-2967][SQL] Follow-up: Also copy hash expressions in sort based shuffle fix. #2072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,15 @@ case class Exchange(newPartitioning: Partitioning, child: SparkPlan) extends Una
case HashPartitioning(expressions, numPartitions) =>
// TODO: Eliminate redundant expressions in grouping key and value.
val rdd = child.execute().mapPartitions { iter =>
@transient val hashExpressions =
newMutableProjection(expressions, child.output)()

if (sortBasedShuffleOn) {
@transient val hashExpressions =
Copy link
Contributor

@chenghao-intel chenghao-intel Aug 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the @transient ?

newProjection(expressions, child.output)

iter.map(r => (hashExpressions(r), r.copy()))
} else {
@transient val hashExpressions =
newMutableProjection(expressions, child.output)()

val mutablePair = new MutablePair[Row, Row]()
iter.map(r => mutablePair.update(hashExpressions(r), r))
}
Expand Down