[SPARK-23094] Fix invalid character handling in JsonDataSource #20302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
LGTM |
|
Test build #86304 has finished for PR 20302 at commit
|
Member
|
retest this please |
Member
|
LGTM |
HyukjinKwon
reviewed
Jan 18, 2018
| } | ||
| } | ||
|
|
||
| test("invalid json with leading nulls - from dataset") { |
Member
There was a problem hiding this comment.
Nit: this case looks already passing tho, and I thought we should put this in JsonSuite.
Member
There was a problem hiding this comment.
The whole suite should be moved. Not related to this PR. I will take this.
Member
There was a problem hiding this comment.
I think usually we encourage to put the test cases in a better suite, in-place.
Member
There was a problem hiding this comment.
This test suite is still in org.apache.spark.sql.sources. We should move these test suite to /sql/core
|
Test build #86312 has finished for PR 20302 at commit
|
Contributor
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Jan 18, 2018
## What changes were proposed in this pull request? There were two related fixes regarding `from_json`, `get_json_object` and `json_tuple` ([Fix #1](c8803c0), [Fix #2](86174ea)), but they weren't comprehensive it seems. I wanted to extend those fixes to all the parsers, and add tests for each case. ## How was this patch tested? Regression tests Author: Burak Yavuz <[email protected]> Closes #20302 from brkyvz/json-invfix. (cherry picked from commit e01919e) Signed-off-by: hyukjinkwon <[email protected]>
Member
|
Merged to master and branch-2.3. |
asfgit
pushed a commit
that referenced
this pull request
Feb 15, 2018
## What changes were proposed in this pull request? This PR is to revert the PR #20302, because it causes a regression. ## How was this patch tested? N/A Author: gatorsmile <[email protected]> Closes #20614 from gatorsmile/revertJsonFix. (cherry picked from commit 95e4b49) Signed-off-by: gatorsmile <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Feb 15, 2018
## What changes were proposed in this pull request? This PR is to revert the PR #20302, because it causes a regression. ## How was this patch tested? N/A Author: gatorsmile <[email protected]> Closes #20614 from gatorsmile/revertJsonFix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There were two related fixes regarding
from_json,get_json_objectandjson_tuple(Fix #1,Fix #2), but they weren't comprehensive it seems. I wanted to extend those fixes to all the parsers, and add tests for each case.
How was this patch tested?
Regression tests