Skip to content

[SPARK-22900] [Spark-Streaming] Remove unnecessary restrict for streaming dynamic allocation #20078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sharkdtu wants to merge 1 commit into from
Closed

[SPARK-22900] [Spark-Streaming] Remove unnecessary restrict for streaming dynamic allocation #20078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions ...aming/src/main/scala/org/apache/spark/streaming/scheduler/ExecutorAllocationManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,12 +202,7 @@ private[streaming] object ExecutorAllocationManager extends Logging {
val MAX_EXECUTORS_KEY = "spark.streaming.dynamicAllocation.maxExecutors"

def isDynamicAllocationEnabled(conf: SparkConf): Boolean = {
val numExecutor = conf.getInt("spark.executor.instances", 0)
val streamingDynamicAllocationEnabled = conf.getBoolean(ENABLED_KEY, false)
if (numExecutor != 0 && streamingDynamicAllocationEnabled) {
throw new IllegalArgumentException(
"Dynamic Allocation for streaming cannot be enabled while spark.executor.instances is set.")
}
if (Utils.isDynamicAllocationEnabled(conf) && streamingDynamicAllocationEnabled) {
throw new IllegalArgumentException(
"""
Expand All @@ -217,7 +212,7 @@ private[streaming] object ExecutorAllocationManager extends Logging {
""".stripMargin)
}
val testing = conf.getBoolean("spark.streaming.dynamicAllocation.testing", false)
numExecutor == 0 && streamingDynamicAllocationEnabled && (!Utils.isLocalMaster(conf) || testing)
streamingDynamicAllocationEnabled && (!Utils.isLocalMaster(conf) || testing)
}

def createIfEnabled(
Expand Down