[DO-NOT-MERGE] Check if 19721 breaks a CRAN #19957
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What changes were proposed in this pull request? since hive 2.0+ upgrades log4j to log4j2，a lot of [changes](https://issues.apache.org/jira/browse/HIVE-11304) are made working on it. as spark is not to ready to update its inner hive version(1.2.1) , so I manage to make little changes. the function registerCurrentOperationLog is moved from SQLOperstion to its parent class ExecuteStatementOperation so spark can use it. ## How was this patch tested? manual test Author: zouchenjun <[email protected]> Closes apache#19721 from ChenjunZou/operation-log.
Member
|
I think the CRAN break is not caused by that PR #19721 |
Member
|
The failure should not be related to Spark |
Member
Author
|
Ah, sure. I just wanted to double check. Thanks @gatorsmile! |
Member
Author
|
Could I revert a04f2be back maybe? |
Member
|
I prefer to asking the original author for resubmitting the PR. |
Member
Author
|
Sure, that also works. Thanks @gatorsmile. |
|
Test build #84802 has finished for PR 19957 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Do not merge this. Simply to run a build and check the results. Will close this as soon as the build is triggered.
How was this patch tested?
N/A