[SPARK-14650][REPL][BUILD] Compile Spark REPL for Scala 2.12 #19612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in ILoop; remove direct dependence on older jline
srowen
commented
Oct 30, 2017
| <artifactId>antlr4-runtime</artifactId> | ||
| <version>${antlr4.version}</version> | ||
| </dependency> | ||
| <dependency> |
Member
Author
There was a problem hiding this comment.
This caused a problem in Scala 2.12, but, doesn't seem like we have any direct dependency on jline anyway
| processLine("import spark.implicits._") | ||
| processLine("import spark.sql") | ||
| processLine("import org.apache.spark.sql.functions._") | ||
| command("import org.apache.spark.SparkContext._") |
Member
Author
There was a problem hiding this comment.
This was the real change. Also part of the reason Spark didn't work in 2.11.11. This avoids waiting on ILoop.globalFuture which isn't initialized when processLine gets called anymore
Member
Author
|
(Note this is a follow-up to #19307) |
|
Test build #83227 has finished for PR 19612 at commit
|
|
Test build #83228 has started for PR 19612 at commit |
|
Test build #3969 has finished for PR 19612 at commit
|
Member
Author
|
Merged to master |
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Nov 2, 2017
## What changes were proposed in this pull request? Spark REPL changes for Scala 2.12.4: use command(), not processLine() in ILoop; remove direct dependence on older jline. Not sure whether this became needed in 2.12.4 or just missed this before. This makes spark-shell work in 2.12. ## How was this patch tested? Existing tests; manual run of spark-shell in 2.11, 2.12 builds Author: Sean Owen <[email protected]> Closes apache#19612 from srowen/SPARK-14650.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Spark REPL changes for Scala 2.12.4: use command(), not processLine() in ILoop; remove direct dependence on older jline. Not sure whether this became needed in 2.12.4 or just missed this before. This makes spark-shell work in 2.12.
How was this patch tested?
Existing tests; manual run of spark-shell in 2.11, 2.12 builds