Skip to content

Conversation

@gengliangwang
Copy link
Member

What changes were proposed in this pull request?

Add comments for specifying the position of batch "Check Cartesian Products", as @rxin suggested in #19362 .

How was this patch tested?

Unit test

@SparkQA
Copy link

SparkQA commented Sep 28, 2017

Test build #82274 has finished for PR 19379 at commit efd73ea.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gengliangwang
Copy link
Member Author

retest this please.

@SparkQA
Copy link

SparkQA commented Sep 28, 2017

Test build #82276 has finished for PR 19379 at commit efd73ea.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatorsmile
Copy link
Member

Thanks! Merged to master

@asfgit asfgit closed this in 0fa4dbe Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants