Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Sep 23, 2017

What changes were proposed in this pull request?

This PR proposes to remove assume in Utils.resolveURIs and replace assume to assert in Utils.resolveURI in the test cases in UtilsSuite.

It looks Utils.resolveURIs supports multiple but also single paths as input. So, it looks not meaningful to check if the input has ,.

For the test for Utils.resolveURI, I replaced it to assert because it looks taking single path and in order to prevent future mistakes when adding more tests here.

For assume in HiveDDLSuite, it looks it should be assert to test at the last

How was this patch tested?

Fixed unit tests.

@HyukjinKwon
Copy link
Member Author

@vanzin, Could you take a look when you are available please?

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I wonder if there are more typos like this. There are a few legitimate assumes about windows

@HyukjinKwon
Copy link
Member Author

Will check other assumes too soon and be back.

@HyukjinKwon
Copy link
Member Author

I checked other instances of org.scalatest.Assertions.assume. I am quite sure of the ones here I added. I didn't add ones I am less sure of.

@SparkQA
Copy link

SparkQA commented Sep 23, 2017

Test build #82114 has finished for PR 19332 at commit beaedb0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon HyukjinKwon changed the title [SPARK-22093][TESTS] Fixes assume in the tests for Utils.resolveURIs and Utils.resolveURI [SPARK-22093][TESTS] Fixes assume in the tests for Utils.resolveURIs, Utils.resolveURI and HiveDDLSuite Sep 23, 2017
@HyukjinKwon HyukjinKwon changed the title [SPARK-22093][TESTS] Fixes assume in the tests for Utils.resolveURIs, Utils.resolveURI and HiveDDLSuite [SPARK-22093][TESTS] Fixes assume in UtilsSuite and HiveDDLSuite Sep 23, 2017
@SparkQA
Copy link

SparkQA commented Sep 23, 2017

Test build #82117 has finished for PR 19332 at commit c32f65b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@HyukjinKwon
Copy link
Member Author

Merged to master.

Thank you @srowen and @dongjoon-hyun.

@asfgit asfgit closed this in 9d48bd0 Sep 24, 2017
@HyukjinKwon HyukjinKwon deleted the SPARK-22093 branch January 2, 2018 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants