-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-22099] The 'job ids' list style needs to be changed in the SQL page. #19320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@HyukjinKwon @jerryshao @ajbozarth |
srowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about just space-separated? the braces all run together kind of overwhelm the digits
|
Why braces? just seems like noise |
|
Do you want to get rid of braces? Then the JDBC / ODBC Server page also needs to remove the braces. But I think there is a better distinction between brackets This is the job id. |
|
I see, you're saying the display of a bunch of job IDs is like "[1] [2] [3]" elsewhere? consistency is the most important thing IMHO. I'd just match whatever a similar column does elsewhere. |
|
In JDBC / ODBC Server page.There are no other places yet. |
|
Do you agree with my PR or against my PR? |
|
I agree with making things consistent. The question is, I guess, what the JDBC/ODBC page does. You can match that. |
|
ok to test |
|
Test build #82103 has finished for PR 19320 at commit
|
|
Merged to master |


What changes were proposed in this pull request?
The 'job ids' list style needs to be changed in the SQL page. There are two reasons:
If a job id is a line, there are a lot of job ids, then the table row height will be high. As shown below:

should be consistent with the 'JDBC / ODBC Server' page style, I am in this way to modify the style. As shown below:

My changes are as follows:

How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.