Skip to content

Clean unused code in SortShuffleWriter #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
colorant wants to merge 1 commit into from
Closed

Clean unused code in SortShuffleWriter #1882

colorant wants to merge 1 commit into from

Conversation

@colorant
Copy link
Contributor

@colorant colorant commented Aug 11, 2014

Just clean unused code which have been moved into ExternalSorter.

@SparkQA
Copy link

SparkQA commented Aug 11, 2014

QA tests have started for PR 1882. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18295/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 11, 2014

QA results for PR 1882:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18295/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 13, 2014

QA tests have started for PR 1882. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18415/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 13, 2014

QA results for PR 1882:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18415/consoleFull

@JoshRosen
Copy link
Contributor

JoshRosen commented Aug 24, 2014

LGTM, so I've merged this into master. Thanks!

@asfgit asfgit closed this in 8861cdf Aug 24, 2014
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@colorant @conviva-zz
Clean unused code in SortShuffleWriter
3507caa 
Just clean unused code which have been moved into ExternalSorter.

Author: Raymond Liu <[email protected]>

Closes apache#1882 from colorant/sortShuffleWriter and squashes the following commits:

e6337be [Raymond Liu] Clean unused code in SortShuffleWriter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colorant @SparkQA @JoshRosen