Skip to content

[SPARK-21297] [WEB-UI]Add count in 'JDBC/ODBC Server' page. #18525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guoxiaolongzte wants to merge 2 commits into from
Closed

[SPARK-21297] [WEB-UI]Add count in 'JDBC/ODBC Server' page. #18525

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ced8e70
[SPARK-21297] Add State in 'Session Statistics' table and add count i…
Jul 4, 2017
4001028
Delete the extra columns
Jul 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...iftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ private[ui] class ThriftServerPage(parent: ThriftServerTab) extends WebUIPage(""
}

val content =
<h5 id="sqlstat">SQL Statistics</h5> ++
<h5 id="sqlstat">SQL Statistics ({numStatement})</h5> ++
<div>
<ul class="unstyled">
{table.getOrElse("No statistics have been generated yet.")}
Expand Down Expand Up @@ -143,7 +143,7 @@ private[ui] class ThriftServerPage(parent: ThriftServerTab) extends WebUIPage(""
val numBatches = sessionList.size
val table = if (numBatches > 0) {
val dataRows = sessionList.sortBy(_.startTimestamp).reverse
val headerRow = Seq("User", "IP", "Session ID", "Start Time", "Finish Time", "Duration",
val headerRow = Seq("User", "IP", "Session ID", "State", "Start Time", "Finish Time", "Duration",
"Total Execute")
def generateDataRow(session: SessionInfo): Seq[Node] = {
val sessionLink = "%s/%s/session?id=%s"
Expand All @@ -152,6 +152,7 @@ private[ui] class ThriftServerPage(parent: ThriftServerTab) extends WebUIPage(""
<td> {session.userName} </td>
<td> {session.ip} </td>
<td> <a href={sessionLink}> {session.sessionId} </a> </td>
<td> {if (session.finishTimestamp > 0) "offline" else "online"} </td>
Copy link
Member

@ajbozarth ajbozarth Jul 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this is necessary? This same logic is applied to the "Finish Time" below. I don't think adding a column here is worthwhile.

Copy link
Author

@guoxiaolongzte guoxiaolongzte Jul 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but add this column, it is easy to observe and view. If you still do not recognize it, I will delete this column.Thanks.

Copy link
Member

@ajbozarth ajbozarth Jul 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be easier but it's still duplicate info, I don't think the extra column is needed

Copy link
Author

@guoxiaolongzte guoxiaolongzte Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have deleted extra columns.

<td> {formatDate(session.startTimestamp)} </td>
<td> {if (session.finishTimestamp > 0) formatDate(session.finishTimestamp)} </td>
<td> {formatDurationOption(Some(session.totalTime))} </td>
Expand All @@ -164,7 +165,7 @@ private[ui] class ThriftServerPage(parent: ThriftServerTab) extends WebUIPage(""
}

val content =
<h5 id="sessionstat">Session Statistics</h5> ++
<h5 id="sessionstat">Session Statistics ({numBatches})</h5> ++
<div>
<ul class="unstyled">
{table.getOrElse("No statistics have been generated yet.")}
Expand Down