Skip to content

[SPARK-21169] [core] Make sure to update application status to RUNNING if executors are accepted and RUNNING after recovery #18414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srini-daruna wants to merge 3 commits into from
Closed

[SPARK-21169] [core] Make sure to update application status to RUNNING if executors are accepted and RUNNING after recovery #18414

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e48a0b0
Update status of application to RUNNING if executors are accepted and…
Jun 25, 2017
703742c
Adding changes necessary to move application state to RUNNING,if exec…
Jun 25, 2017
b3ea335
Changes to improve logic
Jun 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions core/src/main/scala/org/apache/spark/deploy/master/Master.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,6 +563,19 @@ private[deploy] class Master(
}
}

// Update application state if executors are accepted and RUNNING
apps.foreach(appInfo => {
val app = idToApp(appInfo.id)
apps.foreach(f = appInfo => {
Copy link

@brad-kaiser brad-kaiser Jun 25, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be more clear to write foreach like this. You don't need the extra parentheses.

apps.foreach { appInfo =>
  ...
}

Copy link
Author

@srini-daruna srini-daruna Jun 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Bad, IDE auto corrected few things. Please review the latest update

val app = idToApp(appInfo.id)
if (app.executors.size > 0 &&
Copy link

@brad-kaiser brad-kaiser Jun 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be more clear to write this condition like this

if (app.executors.nonEmpty && app.executors.forall(_._2.state == ExecutorState.RUNNING))

app.executors.filter(_._2.state != ExecutorState.RUNNING).isEmpty) {
app.state = ApplicationState.RUNNING
logInfo(s"Application :: ${app.id} status updated to RUNNING state")
}
})
})

state = RecoveryState.ALIVE
schedule()
logInfo("Recovery complete - resuming operations!")
Expand Down