[SPARK-21057][ML] Do not use a PascalDistribution in countApprox #18276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #77931 has finished for PR 18276 at commit
|
Member
|
Retest this please. |
|
Test build #77938 has finished for PR 18276 at commit
|
|
Test build #77987 has finished for PR 18276 at commit
|
Member
Author
|
Merged to master |
lovasoa
reviewed
Jun 14, 2017
| // p of the data. This suggests data is counted at a rate of sum / p across the whole data | ||
| // set. The total expected count from the rest is distributed as | ||
| // (1-p) Poisson(sum / p) = Poisson(sum*(1-p)/p) | ||
| val dist = new PoissonDistribution(sum * (1 - p) / p) |
There was a problem hiding this comment.
@srowen I know it is a little late for a review, but now that we have a single distribution, it would make the code clearer to estimate directly the total count with the poisson distribution. That is removing the 1-p here and the sum + in the final BoundedDouble.
dataknocker
pushed a commit
to dataknocker/spark
that referenced
this pull request
Jun 16, 2017
## What changes were proposed in this pull request? Use Poisson analysis for approx count in all cases. ## How was this patch tested? Existing tests. Author: Sean Owen <[email protected]> Closes apache#18276 from srowen/SPARK-21057.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use Poisson analysis for approx count in all cases.
How was this patch tested?
Existing tests.