[SPARK-21006][TESTS][FOLLOW-UP]Some Worker's RpcEnv is leaked in WorkerSuite

[10110346]

What changes were proposed in this pull request?

Create rpcEnv and run later needs shutdown. as #18226

How was this patch tested?

unit test

[srowen]

@10110346 do you know of other related changes? we should make them all at once.

[SparkQA]

Test build #77873 has finished for PR 18259 at commit 77653f4.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
• class WorkerSuite extends SparkFunSuite with Matchers with BeforeAndAfter

[srowen]

Shouldn't this be override def after(): Unit = {?

[10110346]

@srowen Because BeforeAndAfter is a trait,so we can simplify.
I referenced the 'MasterSuite.scala'

[srowen]

That's bad practice, and why override exists. For example if you wrote afer { you'd maybe never notice that your cleanup code was silently not being triggered.

The code doesn't do this consistently, but more often does write the full declaration, which is probably a good idea. I'd recommend changing this one.

[10110346]

@srowen I agree with you, i will change this one,thanks

[10110346]

@srowen I have tried to change it, but after must write like this

[10110346]

@srowen Thanks. I have checked the whole project,there are no more related changes

[srowen]

That's bad practice, and why override exists. For example if you wrote afer { you'd maybe never notice that your cleanup code was silently not being triggered.

The code doesn't do this consistently, but more often does write the full declaration, which is probably a good idea. I'd recommend changing this one.

[srowen]

Space before

[srowen]

Space before for readability

[SparkQA]

Test build #77929 has finished for PR 18259 at commit d4ee0ce.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
• class WorkerSuite extends SparkFunSuite with Matchers with BeforeAndAfter

[SparkQA]

Test build #77955 has finished for PR 18259 at commit 67913fd.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
• class WorkerSuite extends SparkFunSuite with Matchers with BeforeAndAfter

[SparkQA]

Test build #77964 has started for PR 18259 at commit 4787b9b.

[10110346]

Jenkins, retest this please

[SparkQA]

Test build #77980 has finished for PR 18259 at commit 4787b9b.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
• class WorkerSuite extends SparkFunSuite with Matchers with BeforeAndAfter

[srowen]

Merged to master