Fixed typo in sql.functions #18254
Closed
Fixed typo in sql.functions #18254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
That's fine, though we usually ask people to look for typos more broadly, so we're not handling a bunch of one-offs. Have a look for similar typos or the rest of the file if you would |
Author
|
Sure. |
|
Test build #3789 has finished for PR 18254 at commit
|
Member
|
Merged to master |
dataknocker
pushed a commit
to dataknocker/spark
that referenced
this pull request
Jun 16, 2017
## What changes were proposed in this pull request? I fixed a typo in the Scaladoc for the method `def struct(cols: Column*): Column`. 'retained' was misspelt as 'remained'. ## How was this patch tested? Before: Creates a new struct column. If the input column is a column in a `DataFrame`, or a derived column expression that is named (i.e. aliased), its name would be **remained** as the StructField's name, otherwise, the newly generated StructField's name would be auto generated as `col` with a suffix `index + 1`, i.e. col1, col2, col3, ... After: Creates a new struct column. If the input column is a column in a `DataFrame`, or a derived column expression that is named (i.e. aliased), its name would be **retained** as the StructField's name, otherwise, the newly generated StructField's name would be auto generated as `col` with a suffix `index + 1`, i.e. col1, col2, col3, ... Author: sujithjay <[email protected]> Closes apache#18254 from sujithjay/fix-typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I fixed a typo in the Scaladoc for the method
def struct(cols: Column*): Column. 'retained' was misspelt as 'remained'.How was this patch tested?
Before:
Creates a new struct column.
If the input column is a column in a
DataFrame, or a derived column expressionthat is named (i.e. aliased), its name would be remained as the StructField's name,
otherwise, the newly generated StructField's name would be auto generated as
colwith a suffixindex + 1, i.e. col1, col2, col3, ...After:
Creates a new struct column.
If the input column is a column in a
DataFrame, or a derived column expressionthat is named (i.e. aliased), its name would be retained as the StructField's name,
otherwise, the newly generated StructField's name would be auto generated as
colwith a suffixindex + 1, i.e. col1, col2, col3, ...