Skip to content

[YARN] [SPARK-20756] yarn-shuffle jar references unshaded guava #17990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markgrover wants to merge 2 commits into from
Closed

[YARN] [SPARK-20756] yarn-shuffle jar references unshaded guava #17990

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
461ee5a
[YARN] [SPARK-20756] yarn-shuffle jar has references to unshaded guav…
markgrover May 16, 2017
14d1d4d
Using inheritance instead
markgrover May 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/network-yarn/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@
<includes>
<include>*:*</include>
</includes>
<excludes>
<exclude>org.scala-lang:scala-library</exclude>
</excludes>
</artifactSet>
<filters>
<filter>
Expand All @@ -113,6 +116,13 @@
<include>io.netty.**</include>
</includes>
</relocation>
<relocation>
<pattern>com.google.common</pattern>
Copy link
Contributor

@vanzin vanzin May 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why you chose copy & paste over inheritance?

Copy link
Member Author

@markgrover markgrover May 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed it to use inheritance. They looked equivalent but on second thought inheritance is better so any changes to parent pom trickle down automatically.

<shadedPattern>${spark.shade.packageName}.guava</shadedPattern>
<includes>
<include>com.google.**</include>
</includes>
</relocation>
</relocations>
</configuration>
<executions>
Expand Down