Skip to content

[SPARK-19903][PYSPARK][SS] window operator miss the watermark metadata of time column #17371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uncleGen wants to merge 2 commits into from
Closed

[SPARK-19903][PYSPARK][SS] window operator miss the watermark metadata of time column #17371

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
654c512
bug fix: window operator miss the `watermark` metadata of time column
uncleGen Mar 21, 2017
890c6e6
avoid to break api
uncleGen Mar 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion python/pyspark/sql/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,7 +1163,10 @@ def check_string_field(field, fieldName):
raise TypeError("%s should be provided as a string" % fieldName)

sc = SparkContext._active_spark_context
time_col = _to_java_column(timeColumn)
if isinstance(timeColumn, Column):
Copy link
Member

@viirya viirya Mar 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, doesn't this break the current API?

Copy link
Contributor Author

@uncleGen uncleGen Mar 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, it is OK for current codebase. Am I missing something?

Copy link
Member

@viirya viirya Mar 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this change, you can't pass in a Column. But it is supported for now.

Copy link
Contributor Author

@uncleGen uncleGen Mar 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viirya Sounds reasonable, I pushed an update, take a review please.

raise TypeError("timeColumn should be the name of time column, and provided as a string.")
else:
time_col = _to_java_column(timeColumn)
check_string_field(windowDuration, "windowDuration")
if slideDuration and startTime:
check_string_field(slideDuration, "slideDuration")
Expand Down