[SPARK-19869][SQL]move table related ddl from ddl.scala to tables.scala #17211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #74209 has finished for PR 17211 at commit
|
Contributor
Author
|
cc @cloud-fan |
|
Test build #74210 has finished for PR 17211 at commit
|
gatorsmile
reviewed
Mar 12, 2017
| AttributeReference("database_description_item", StringType, nullable = false)() :: | ||
| AttributeReference("database_description_value", StringType, nullable = false)() :: Nil | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
The remaining commands are database only. We can move the database related commands to org.apache.spark.sql.execution.command.databases.scala.
Contributor
Author
There was a problem hiding this comment.
ok~ thanks, another problem is now the lines of tables.scala is 1594, this is too large, should we need to split it to reduce the lines of a file?
Member
|
This change might cause people hard to track the change history. Maybe we can close this PR? |
Member
|
We are closing it due to inactivity. please do reopen if you want to push it forward. Thanks! |
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
## What changes were proposed in this pull request? This PR proposes to close stale PRs, mostly the same instances with apache#18017 I believe the author in apache#14807 removed his account. Closes apache#7075 Closes apache#8927 Closes apache#9202 Closes apache#9366 Closes apache#10861 Closes apache#11420 Closes apache#12356 Closes apache#13028 Closes apache#13506 Closes apache#14191 Closes apache#14198 Closes apache#14330 Closes apache#14807 Closes apache#15839 Closes apache#16225 Closes apache#16685 Closes apache#16692 Closes apache#16995 Closes apache#17181 Closes apache#17211 Closes apache#17235 Closes apache#17237 Closes apache#17248 Closes apache#17341 Closes apache#17708 Closes apache#17716 Closes apache#17721 Closes apache#17937 Added: Closes apache#14739 Closes apache#17139 Closes apache#17445 Closes apache#18042 Closes apache#18359 Added: Closes apache#16450 Closes apache#16525 Closes apache#17738 Added: Closes apache#16458 Closes apache#16508 Closes apache#17714 Added: Closes apache#17830 Closes apache#14742 ## How was this patch tested? N/A Author: hyukjinkwon <[email protected]> Closes apache#18417 from HyukjinKwon/close-stale-pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
move table related ddl from ddl.scala to tables.scala
How was this patch tested?
N/A