-
Notifications
You must be signed in to change notification settings - Fork 29k
[WIP][SPARK-19257][SQL]CatalogStorageFormat.locationUri should be java.net.URI #16619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #71514 has finished for PR 16619 at commit
|
|
Test build #71515 has finished for PR 16619 at commit
|
|
Test build #71516 has finished for PR 16619 at commit
|
|
Test build #71518 has finished for PR 16619 at commit
|
|
Test build #71700 has finished for PR 16619 at commit
|
|
Test build #71766 has finished for PR 16619 at commit
|
|
Should this be closed in favor of #17149 ? |
|
yes I will close it , thanks! @srowen |
What changes were proposed in this pull request?
Currently we treat
CatalogStorageFormat.locationUrias URI string and always convert it to path bynew Path(new URI(locationUri))It will be safer if we can make the type of
CatalogStorageFormat.locationUrijava.net.URI. We should finish the TODO in https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala#L50-L52How was this patch tested?