[SPARK-17502] [17609] [SQL] [Backport] [2.0] Fix Multiple Bugs in DDL Statements on Temporary Views #15174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #65702 has finished for PR 15174 at commit
|
Member
Author
|
cc @cloud-fan |
Contributor
|
LGTM, if you have time, can you also include #15160? they are kind of related. thanks! |
Member
Author
|
Sure, will do it. |
gatorsmile
changed the title
Member
Author
|
FYI, most code changes of #15160 in |
gatorsmile
changed the title
cloud-fan
reviewed
Sep 22, 2016
| sessionState.catalog.lookupRelation(tableIdentWithDB)) match { | ||
| // Pass a table identifier with database part, so that `tableExists` won't check temp | ||
| // views unexpectedly. | ||
| EliminateSubqueryAliases(sessionState.catalog.lookupRelation(tableIdentWithDB)) match { |
Contributor
There was a problem hiding this comment.
we don't need tableIdentWithDB in CreateDataSourceTableCommand right?
Mironor
reviewed
Sep 22, 2016
| """.stripMargin) | ||
|
|
||
| case InsertIntoTable(t, _, _, _, _) | ||
| if !t.isInstanceOf[LeafNode] || |
There was a problem hiding this comment.
I was wondering why not replacing these one-letter values with something more explicit (like table in the following case) ? I understand that this is not the purpose of the PR, but just interested if it is normal to highlight those "style" things in PR discussion or not.
Member
Author
There was a problem hiding this comment.
This PR is to backport the fix from the master branch to Spark 2.0 branch. I think your comment is valid. You can submit a PR for improving the code style. Thanks!
|
Test build #65763 has finished for PR 15174 at commit
|
|
Test build #65777 has finished for PR 15174 at commit
|
Contributor
|
thanks, merging to 2.0! |
asfgit
pushed a commit
that referenced
this pull request
Sep 23, 2016
…tements on Temporary Views ### What changes were proposed in this pull request? This PR is to backport #15054 and #15160 to Spark 2.0. - When the permanent tables/views do not exist but the temporary view exists, the expected error should be `NoSuchTableException` for partition-related ALTER TABLE commands. However, it always reports a confusing error message. For example, ``` Partition spec is invalid. The spec (a, b) must match the partition spec () defined in table '`testview`'; ``` - When the permanent tables/views do not exist but the temporary view exists, the expected error should be `NoSuchTableException` for `ALTER TABLE ... UNSET TBLPROPERTIES`. However, it reports a missing table property. For example, ``` Attempted to unset non-existent property 'p' in table '`testView`'; ``` - When `ANALYZE TABLE` is called on a view or a temporary view, we should issue an error message. However, it reports a strange error: ``` ANALYZE TABLE is not supported for Project ``` - When inserting into a temporary view that is generated from `Range`, we will get the following error message: ``` assertion failed: No plan for 'InsertIntoTable Range (0, 10, step=1, splits=Some(1)), false, false +- Project [1 AS 1#20] +- OneRowRelation$ ``` This PR is to fix the above four issues. There is no place in Spark SQL that need `SessionCatalog.tableExists` to check temp views, so this PR makes `SessionCatalog.tableExists` only check permanent table/view and removes some hacks. ### How was this patch tested? Added multiple test cases Author: gatorsmile <[email protected]> Closes #15174 from gatorsmile/PR15054Backport.
Member
Author
|
Let me close it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is to backport #15054 and #15160 to Spark 2.0.
NoSuchTableExceptionfor partition-related ALTER TABLE commands. However, it always reports a confusing error message. For example,NoSuchTableExceptionforALTER TABLE ... UNSET TBLPROPERTIES. However, it reports a missing table property. For example,ANALYZE TABLEis called on a view or a temporary view, we should issue an error message. However, it reports a strange error:Range, we will get the following error message:This PR is to fix the above four issues.
There is no place in Spark SQL that need
SessionCatalog.tableExiststo check temp views, so this PR makesSessionCatalog.tableExistsonly check permanent table/view and removes some hacks.How was this patch tested?
Added multiple test cases