Skip to content

Conversation

@gatorsmile
Copy link
Member

What changes were proposed in this pull request?

This PR is part of the original PR: #14625.

Based on file-based SQL end-to-end testing framework in SQLQueryTestSuite, this PR is to create test cases for left-semi joins and using joins. We did not change the data and query, and thus, the queries and results should match the original ones.

In addition, this PR also moved the test cases from SQLQuerySuite to DataFrameJoinSuite, because these test cases are not using SQL.

How was this patch tested?

N/A

@gatorsmile
Copy link
Member Author

To reviewers: to make it easier to review, each commit can be reviewed separately. The name of each commit is self descriptive

@SparkQA
Copy link

SparkQA commented Aug 24, 2016

Test build #64371 has finished for PR 14793 at commit 6b6e257.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

@rxin How about this one? This is porting our existing test cases, instead of HiveCompatbilitySuite

@gatorsmile
Copy link
Member Author

cc @cloud-fan @clockfly

@cloud-fan
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Sep 2, 2016

Test build #64837 has finished for PR 14793 at commit 81c404e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

retest this please

@SparkQA
Copy link

SparkQA commented Sep 13, 2016

Test build #65300 has finished for PR 14793 at commit 81c404e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile gatorsmile closed this Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants