-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-16508][SparkR] Fix CRAN undocumented/duplicated arguments warnings. #14705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -932,7 +932,7 @@ setMethod("sample_frac", | |
| #' @param x a SparkDataFrame. | ||
| #' @family SparkDataFrame functions | ||
| #' @rdname nrow | ||
| #' @name count | ||
| #' @name nrow | ||
| #' @aliases count,SparkDataFrame-method | ||
| #' @export | ||
| #' @examples | ||
|
|
@@ -1214,9 +1214,9 @@ setMethod("toRDD", | |
| #' | ||
| #' Groups the SparkDataFrame using the specified columns, so we can run aggregation on them. | ||
| #' | ||
| #' @param x a SparkDataFrame | ||
| #' @param x a SparkDataFrame. | ||
| #' @param ... variable(s) (character names(s) or Column(s)) to group on. | ||
| #' @return a GroupedData | ||
| #' @return A GroupedData. | ||
| #' @family SparkDataFrame functions | ||
| #' @aliases groupBy,SparkDataFrame-method | ||
| #' @rdname groupBy | ||
|
|
@@ -3037,8 +3037,8 @@ setMethod("str", | |
| #' This is a no-op if schema doesn't contain column name(s). | ||
| #' | ||
| #' @param x a SparkDataFrame. | ||
| #' @param ... further arguments to be passed to or from other methods. | ||
| #' @param col a character vector of column names or a Column. | ||
| #' @param ... further arguments to be passed to or from other methods. | ||
| #' @return A SparkDataFrame. | ||
| #' | ||
| #' @family SparkDataFrame functions | ||
|
|
@@ -3058,7 +3058,7 @@ setMethod("str", | |
| #' @note drop since 2.0.0 | ||
| setMethod("drop", | ||
| signature(x = "SparkDataFrame"), | ||
| function(x, col) { | ||
| function(x, col, ...) { | ||
| stopifnot(class(col) == "character" || class(col) == "Column") | ||
|
|
||
| if (class(col) == "Column") { | ||
|
|
@@ -3218,11 +3218,11 @@ setMethod("histogram", | |
| #' and to not change the existing data. | ||
| #' } | ||
| #' | ||
| #' @param x A SparkDataFrame | ||
| #' @param url JDBC database url of the form `jdbc:subprotocol:subname` | ||
| #' @param tableName The name of the table in the external database | ||
| #' @param x s SparkDataFrame. | ||
| #' @param url JDBC database url of the form `jdbc:subprotocol:subname`. | ||
| #' @param tableName yhe name of the table in the external database. | ||
| #' @param mode one of 'append', 'overwrite', 'error', 'ignore' save mode (it is 'error' by default). | ||
| #' @param ... additional JDBC database connection properties. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @param ... should be last
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. Thanks! |
||
| #' @param mode One of 'append', 'overwrite', 'error', 'ignore' save mode (it is 'error' by default) | ||
| #' @family SparkDataFrame functions | ||
| #' @rdname write.jdbc | ||
| #' @name write.jdbc | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -316,7 +316,7 @@ setMethod("column", | |
| #' | ||
| #' Computes the Pearson Correlation Coefficient for two Columns. | ||
| #' | ||
| #' @param col2 a (second) Column object. | ||
| #' @param col2 a (second) Column. | ||
| #' | ||
| #' @rdname corr | ||
| #' @name corr | ||
|
|
@@ -357,8 +357,8 @@ setMethod("cov", signature(x = "characterOrColumn"), | |
|
|
||
| #' @rdname cov | ||
| #' | ||
| #' @param col1 the first Column object. | ||
| #' @param col2 the second Column object. | ||
| #' @param col1 the first Column. | ||
| #' @param col2 the second Column. | ||
| #' @name covar_samp | ||
| #' @aliases covar_samp,characterOrColumn,characterOrColumn-method | ||
| #' @note covar_samp since 2.0.0 | ||
|
|
@@ -446,8 +446,8 @@ setMethod("cosh", | |
| #' | ||
| #' Returns the number of items in a group. This is a column aggregate function. | ||
| #' | ||
| #' @rdname n | ||
| #' @name n | ||
| #' @rdname count | ||
| #' @name count | ||
| #' @family agg_funcs | ||
| #' @aliases count,Column-method | ||
| #' @export | ||
|
|
@@ -1270,14 +1270,14 @@ setMethod("round", | |
|
|
||
| #' bround | ||
| #' | ||
| #' Returns the value of the column `e` rounded to `scale` decimal places using HALF_EVEN rounding | ||
| #' mode if `scale` >= 0 or at integer part when `scale` < 0. | ||
| #' Returns the value of the column \code{e} rounded to \code{scale} decimal places using HALF_EVEN rounding | ||
| #' mode if \code{scale} >= 0 or at integer part when \code{scale} < 0. | ||
| #' Also known as Gaussian rounding or bankers' rounding that rounds to the nearest even number. | ||
| #' bround(2.5, 0) = 2, bround(3.5, 0) = 4. | ||
| #' | ||
| #' @param x Column to compute on. | ||
| #' @param scale round to \code{scale} digits to the right of the decimal point when \code{scale} > 0, | ||
| #' the nearest even number when \code{scale} = 0, and `scale` digits to the left | ||
| #' the nearest even number when \code{scale} = 0, and \code{scale} digits to the left | ||
| #' of the decimal point when \code{scale} < 0. | ||
| #' @param ... further arguments to be passed to or from other methods. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should this be |
||
| #' @rdname bround | ||
|
|
@@ -2276,8 +2276,7 @@ setMethod("n_distinct", signature(x = "Column"), | |
| countDistinct(x, ...) | ||
| }) | ||
|
|
||
| #' @param x a Column. | ||
| #' @rdname n | ||
| #' @rdname count | ||
| #' @name n | ||
| #' @aliases n,Column-method | ||
| #' @export | ||
|
|
@@ -2655,7 +2654,7 @@ setMethod("expr", signature(x = "character"), | |
| #' Formats the arguments in printf-style and returns the result as a string column. | ||
| #' | ||
| #' @param format a character object of format strings. | ||
| #' @param x a Column object. | ||
| #' @param x a Column. | ||
| #' @param ... additional Column(s). | ||
| #' @family string_funcs | ||
| #' @rdname format_string | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I don't think we should change @name - this should match the function name, "count"
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then the \name{count} would appear in both docs and the check complains...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe leave @name out then? That seems to fix the problem the other time?