Skip to content

[SPARK-13015][MLlib][DOC] Replace example code in mllib-data-types.md using include_example #14006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yinxusen wants to merge 12 commits into from
Closed

[SPARK-13015][MLlib][DOC] Replace example code in mllib-data-types.md using include_example #14006

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4fa23b4
add scala example and fix error prompt in include_example
yinxusen Jun 30, 2016
5ce1ef1
change md file
yinxusen Jun 30, 2016
922ba78
refine modifier
yinxusen Jun 30, 2016
b0e74e3
add sc
yinxusen Jun 30, 2016
51018c9
fix java imports
yinxusen Jun 30, 2016
176a240
refine error prompt
yinxusen Jul 1, 2016
ed271b0
fix QR decompostion error
yinxusen Jul 4, 2016
9e102a6
add spark sqlcontext for toDF
yinxusen Jul 4, 2016
47c7b16
fix type erase for RowMatrix
yinxusen Jul 4, 2016
2f879e2
Merge branch 'master' into SPARK-13015-consolidate
yinxusen Jul 8, 2016
c28fdb8
revert some code
yinxusen Jul 8, 2016
265a62f
merge with master
yinxusen Oct 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/_plugins/include_example.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,20 +85,20 @@ def select_lines(code)
.select { |l, i| l.include? "$example off#{@snippet_label}$" }
.map { |l, i| i }

raise "Start indices amount is not equal to end indices amount, see #{@file}." \
raise "Start indices amount is not equal to end indices amount, see #{@file}, #{@snippet_label}." \
Copy link
Contributor

@liancheng liancheng Jul 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer

... see #{@file} [labeled=#{@snippet_label}].

Otherwise the label itself might be mistaken for a file path.

unless startIndices.size == endIndices.size

raise "No code is selected by include_example, see #{@file}." \
raise "No code is selected by include_example, see #{@file}, #{@snippet_label}." \
if startIndices.size == 0

# Select and join code blocks together, with a space line between each of two continuous
# blocks.
lastIndex = -1
result = ""
startIndices.zip(endIndices).each do |start, endline|
raise "Overlapping between two example code blocks are not allowed, see #{@file}." \
raise "Overlapping between two example code blocks are not allowed, see #{@file}, #{@snippet_label}." \
if start <= lastIndex
raise "$example on$ should not be in the same line with $example off$, see #{@file}." \
raise "$example on$ should not be in the same line with $example off$, see #{@file}, #{@snippet_label}." \
if start == endline
lastIndex = endline
range = Range.new(start + 1, endline - 1)
Expand Down
Loading