Skip to content

Conversation

@techaddict
Copy link
Contributor

What changes were proposed in this pull request?

This is a followup of #12851
Remove SparkSession.withHiveSupport in PySpark and instead use SparkSession.builder. enableHiveSupport

How was this patch tested?

Existing tests.

@andrewor14
Copy link
Contributor

andrewor14 commented May 11, 2016

@techaddict in the future can you try to put more changes in one patch instead of having many small related patches?

@techaddict
Copy link
Contributor Author

Hi @andrewor14 support for enableHiveSupport was added(0903a18) after I started working on removing withHiveSupport in #12851
That's why the Follow Up PR.

@andrewor14
Copy link
Contributor

I see. That's fine then.

@SparkQA
Copy link

SparkQA commented May 11, 2016

Test build #58411 has finished for PR 13063 at commit 413a9ec.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

Merging into master 2.0. Thanks.

asfgit pushed a commit that referenced this pull request May 12, 2016
…port in PySpark

## What changes were proposed in this pull request?
This is a followup of #12851
Remove `SparkSession.withHiveSupport` in PySpark and instead use `SparkSession.builder. enableHiveSupport`

## How was this patch tested?
Existing tests.

Author: Sandeep Singh <[email protected]>

Closes #13063 from techaddict/SPARK-15072-followup.
@asfgit asfgit closed this in db573fc May 12, 2016
@yhuai
Copy link
Contributor

yhuai commented May 12, 2016

There are still places where we use withHiveSupport. Seems our tests did not catch those.

@yhuai
Copy link
Contributor

yhuai commented May 12, 2016

#13069 is the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants