Skip to content

[SPARK-14997]Files in subdirectories are incorrectly considered in sqlContext.read.json() #12774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sbcd90 wants to merge 1 commit into from
Closed

[SPARK-14997]Files in subdirectories are incorrectly considered in sqlContext.read.json() #12774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions ...core/src/main/scala/org/apache/spark/sql/execution/datasources/fileSourceInterfaces.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,14 +376,10 @@ class HDFSFileCatalog(
HadoopFsRelation.shouldFilterOut(name)
}

val (dirs, files) = statuses.partition(_.isDirectory)
val (_, files) = statuses.partition(_.isDirectory)

// It uses [[LinkedHashSet]] since the order of files can affect the results. (SPARK-11500)
if (dirs.isEmpty) {
mutable.LinkedHashSet(files: _*)
} else {
mutable.LinkedHashSet(files: _*) ++ listLeafFiles(dirs.map(_.getPath))
}
mutable.LinkedHashSet(files: _*)
Copy link
Member

@HyukjinKwon HyukjinKwon Apr 29, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure of the difference between 1.6.1 and master? I see this logics are not changed comparing to that interfaces.scala#L467-L472 in branch 1.6.
Also, does this still support to read partitioned tables?

Copy link
Member

@HyukjinKwon HyukjinKwon Apr 29, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I believe there is another method in HadoopFsRelation companion object to list up files parallely. This will use this method based on a threshold. I think that should be also corrected if it is really problematic and there should be tests for them as well.

}
}

Expand Down