Skip to content

Conversation

@JeremyNixon
Copy link
Contributor

This pull request uses {%include_example%} to add an example for the python cross validator to ml-guide.

@mengxr
Copy link
Contributor

mengxr commented Feb 23, 2016

ok to test

@mengxr
Copy link
Contributor

mengxr commented Feb 23, 2016

cc @yinxusen

@SparkQA
Copy link

SparkQA commented Feb 23, 2016

Test build #51790 has finished for PR 11240 at commit cad4f71.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yinxusen
Copy link
Contributor

@mengxr LGTM

@JeremyNixon
Copy link
Contributor Author

@mengxr @yinxusen I made an update to an error in the train-validation-split example, it's currently pointing to the wrong data (was overwritten by https://issues.apache.org/jira/browse/SPARK-13012). Let me know if you'd prefer I create a new JIRA instead.

@yinxusen
Copy link
Contributor

@JeremyNixon There is no need to fix those two examples. Actually we have duplicated example code now - JavaModelSelectionViaTrainValidationSplitExample VS JavaTrainValidationSplitExample, etc. We prepare to remove the duplicated JavaTrainValidationSplitExample later under JIRA https://issues.apache.org/jira/browse/SPARK-13461

@SparkQA
Copy link

SparkQA commented Feb 23, 2016

Test build #51812 has finished for PR 11240 at commit 54d2d08.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JeremyNixon
Copy link
Contributor Author

@yinxusen Great to hear, this PR should be good to go.

@SparkQA
Copy link

SparkQA commented Feb 23, 2016

Test build #51818 has finished for PR 11240 at commit 69aa6d0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Feb 23, 2016

Merged into master. Thanks!

@asfgit asfgit closed this in 230bbea Feb 23, 2016
@JeremyNixon
Copy link
Contributor Author

@mengxr My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants