-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-10759][ML] update cross validator with include_example #11240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ok to test |
|
cc @yinxusen |
|
Test build #51790 has finished for PR 11240 at commit
|
|
@mengxr LGTM |
|
@mengxr @yinxusen I made an update to an error in the train-validation-split example, it's currently pointing to the wrong data (was overwritten by https://issues.apache.org/jira/browse/SPARK-13012). Let me know if you'd prefer I create a new JIRA instead. |
|
@JeremyNixon There is no need to fix those two examples. Actually we have duplicated example code now - JavaModelSelectionViaTrainValidationSplitExample VS JavaTrainValidationSplitExample, etc. We prepare to remove the duplicated JavaTrainValidationSplitExample later under JIRA https://issues.apache.org/jira/browse/SPARK-13461 |
|
Test build #51812 has finished for PR 11240 at commit
|
|
@yinxusen Great to hear, this PR should be good to go. |
|
Test build #51818 has finished for PR 11240 at commit
|
|
Merged into master. Thanks! |
|
@mengxr My pleasure! |
This pull request uses {%include_example%} to add an example for the python cross validator to ml-guide.