Refactor Kafka client configuration to use a new ClientConfig struct #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the Kafka client configuration by introducing a new
ClientConfigstruct to replace the use ofRDKafkaClientConfigdirectly. The changes improve code clarity, encapsulation, and configurability, particularly by adding support for a custom log level. The most important changes include replacingRDKafkaClientConfigwithClientConfigin multiple files, implementing the newClientConfigstruct, and updating theKafkaReportBuilderto use the new configuration.Refactoring Kafka Client Configuration:
Introduction of
ClientConfigstruct:ClientConfigstruct insrc/reporter/kafka.rs, encapsulating Kafka configuration parameters and log levels. It includes methods for setting parameters, setting log levels, and converting toRDKafkaClientConfig. [1] [2]Replacement of
RDKafkaClientConfigwithClientConfig:RDKafkaClientConfiginREADME.mdande2e/src/main.rsto use the newClientConfigstruct. [1] [2] [3]Updates to
KafkaReportBuilder:KafkaReportBuilderto useClientConfig:KafkaReportBuilderstruct and its methods to accept and work withClientConfiginstead ofRDKafkaClientConfig. This includes changes to thenew,new_with_pc, andbuildmethods. [1] [2] [3]These changes enhance the maintainability and flexibility of the Kafka client configuration by abstracting the configuration details into a dedicated struct.