Skip to content

Conversation

@jmjoy
Copy link
Member

@jmjoy jmjoy commented Aug 14, 2022

  1. Upgrade tonic to 0.8.
  2. OnceCellReporter is unnecessary, just replace with OnceCell.

The new version prost now require protoc installed (don't auto build protoc from sources if not exists), so add protoc in CI.
Refer:https://github.com/tokio-rs/prost/releases/tag/v0.11.0

@jmjoy jmjoy added the chore Housekeeping things like CI, license things label Aug 14, 2022
@jmjoy jmjoy self-assigned this Aug 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2022

Codecov Report

Merging #42 (8cface4) into master (b8a4a18) will increase coverage by 0.17%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   27.40%   27.57%   +0.17%     
==========================================
  Files          17       16       -1     
  Lines         478      475       -3     
==========================================
  Hits          131      131              
+ Misses        347      344       -3     
Impacted Files Coverage Δ
src/reporter/mod.rs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmjoy jmjoy marked this pull request as ready for review August 14, 2022 05:33
@jmjoy jmjoy requested a review from wu-sheng August 14, 2022 05:33
@jmjoy jmjoy marked this pull request as draft August 14, 2022 05:58
@jmjoy jmjoy marked this pull request as ready for review August 14, 2022 06:57
@wu-sheng wu-sheng merged commit c64097d into apache:master Aug 14, 2022
@wu-sheng wu-sheng added this to the 0.4.0 milestone Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Housekeeping things like CI, license things

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants