Skip to content

Conversation

@jmjoy
Copy link
Member

@jmjoy jmjoy commented Aug 5, 2022

To add logging and metrics in the future, adjust the structure of the trace.

  1. Rename mod context to trace.
  2. Move reporter to trace, and rename Reporter to TraceReporter, and do so for implementers.
  3. Add the logging mod and base structure.

@jmjoy jmjoy added the enhancement New feature or request label Aug 5, 2022
@jmjoy jmjoy added this to the 0.4.0 milestone Aug 5, 2022
@jmjoy jmjoy requested a review from wu-sheng August 5, 2022 10:41
@jmjoy jmjoy self-assigned this Aug 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2022

Codecov Report

Merging #40 (092ea33) into master (fa8ba85) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   45.23%   45.23%           
=======================================
  Files          14       14           
  Lines         378      378           
=======================================
  Hits          171      171           
  Misses        207      207           
Impacted Files Coverage Δ
src/skywalking_proto/v3/mod.rs 0.00% <ø> (ø)
src/trace/propagation/context.rs 100.00% <ø> (ø)
src/trace/propagation/decoder.rs 91.17% <ø> (ø)
src/trace/propagation/encoder.rs 100.00% <ø> (ø)
src/trace/span.rs 0.00% <ø> (ø)
src/trace/system_time.rs 0.00% <ø> (ø)
src/trace/trace_context.rs 24.48% <ø> (ø)
src/trace/tracer.rs 61.79% <ø> (ø)
tests/propagation.rs 100.00% <ø> (ø)
tests/trace_context.rs 0.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jmjoy jmjoy marked this pull request as ready for review August 5, 2022 10:59
@wu-sheng
Copy link
Member

wu-sheng commented Aug 5, 2022

Move reporter to trace, and rename Reporter to TraceReporter, and do so for implementers.

Mostly, we recommend only having one global reporter for trace, log, and metrics.

@jmjoy
Copy link
Member Author

jmjoy commented Aug 5, 2022

Move reporter to trace, and rename Reporter to TraceReporter, and do so for implementers.

Mostly, we recommend only having one global reporter for trace, log, and metrics.

Alright.

@wu-sheng wu-sheng merged commit c6ec104 into apache:master Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants