Skip to content

Conversation

@jmjoy
Copy link
Member

@jmjoy jmjoy commented Jul 28, 2022

So users can customize the channel inside the tracer, such as using ipc channel.

@codecov-commenter
Copy link

Codecov Report

Merging #37 (cc9ddb7) into master (6232828) will increase coverage by 4.51%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   38.08%   42.59%   +4.51%     
==========================================
  Files          13       14       +1     
  Lines         323      385      +62     
==========================================
+ Hits          123      164      +41     
- Misses        200      221      +21     
Impacted Files Coverage Δ
src/context/tracer.rs 55.20% <51.92%> (+16.31%) ⬆️
src/reporter/log.rs 21.05% <100.00%> (ø)
src/reporter/mod.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@jmjoy jmjoy marked this pull request as ready for review July 28, 2022 12:56
@jmjoy jmjoy self-assigned this Jul 28, 2022
@jmjoy jmjoy added this to the 0.4.0 milestone Jul 28, 2022
@jmjoy jmjoy requested a review from wu-sheng July 28, 2022 13:02
@jmjoy jmjoy added the enhancement New feature or request label Jul 28, 2022
@wu-sheng
Copy link
Member

What is ipc channel? Could you provide a case about how to use this?

@jmjoy
Copy link
Member Author

jmjoy commented Jul 28, 2022

What is ipc channel? Could you provide a case about how to use this?

The ipc channel can transmit data across processes, which is need in some multi-process architecture services (such as nginx and php-fpm), like in https://github.com/jmjoy/php-skywalking-agent/blob/705d08e716f80a3f0cad4c2efd211709bf384adb/src/module.rs#L73.

@wu-sheng
Copy link
Member

OK, so, you want to propagate collected segments or tracing context, or both?

@jmjoy
Copy link
Member Author

jmjoy commented Jul 28, 2022

OK, so, you want to propagate collected segments or tracing context, or both?

Only segments.

@wu-sheng
Copy link
Member

So, generally, you just want one process to report segments? Because this has better perf.?

@jmjoy
Copy link
Member Author

jmjoy commented Jul 28, 2022

So, generally, you just want one process to report segments? Because this has better perf.?

There is one manager process to report segments to skywalking server via grpc, and multi worker process to handle request, generate segments and transmit to manager process via ipc channel.

@wu-sheng wu-sheng merged commit 68103f9 into apache:master Jul 28, 2022
@jmjoy jmjoy deleted the ipc branch July 28, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants