Skip to content

Support Oracle SQL parser correctly extract REGEXP_SUBSTR parameters.#37924

Merged
strongduanmu merged 8 commits intoapache:masterfrom
ClaireLytt:issueNo4
Feb 2, 2026
Merged

Support Oracle SQL parser correctly extract REGEXP_SUBSTR parameters.#37924
strongduanmu merged 8 commits intoapache:masterfrom
ClaireLytt:issueNo4

Conversation

@ClaireLytt
Copy link
Contributor

for #37307

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note


@Override
public ASTNode visitHierarchicalQueryClause(final HierarchicalQueryClauseContext ctx) {
if (null == ctx || null == ctx.getStart() || null == ctx.getStop()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this check meaningful?

Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, merged.

@strongduanmu strongduanmu merged commit 5570606 into apache:master Feb 2, 2026
140 checks passed
@ClaireLytt ClaireLytt deleted the issueNo4 branch February 2, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants