Skip to content

Improve migration consistency check to reflect storage unit maxPoolSize dynamically#36507

Merged
menghaoranss merged 1 commit intoapache:masterfrom
sandynz:pipeline-1
Sep 9, 2025
Merged

Improve migration consistency check to reflect storage unit maxPoolSize dynamically#36507
menghaoranss merged 1 commit intoapache:masterfrom
sandynz:pipeline-1

Conversation

@sandynz
Copy link
Contributor

@sandynz sandynz commented Sep 9, 2025

Changes proposed in this pull request:

  • Improve migration consistency check to reflect storage unit maxPoolSize dynamically

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@menghaoranss menghaoranss merged commit 9a65a82 into apache:master Sep 9, 2025
24 checks passed
@sandynz sandynz deleted the pipeline-1 branch September 9, 2025 09:36
@sandynz
Copy link
Contributor Author

sandynz commented Nov 12, 2025

Usage:
Migration consistency check will build ShardingSphereDataSource with data source configuration from migration job configuration, including maxPoolSize data source property.
If maxPoolSize is not enough for consistency check (there's get connection error message in SHOW MIGRATION CHECK STATUS ...), then we can update maxPoolSize via ALTER STORAGE UNIT .... And restart consistency check job to make maxPoolSize take effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants