Skip to content

Fix the connection leak caused by rollback failure in Proxy#35867

Merged
jiangML merged 2 commits intoapache:masterfrom
RaigorJiang:dev-proxy
Jul 3, 2025
Merged

Fix the connection leak caused by rollback failure in Proxy#35867
jiangML merged 2 commits intoapache:masterfrom
RaigorJiang:dev-proxy

Conversation

@RaigorJiang
Copy link
Contributor

Fixes #35866.

Changes proposed in this pull request:

  • Make sure to call the connection.close() method in the finally block
  • If close fails, print a warn log

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@jiangML jiangML merged commit 0731b44 into apache:master Jul 3, 2025
147 checks passed
@RaigorJiang RaigorJiang deleted the dev-proxy branch July 3, 2025 09:08
makssent pushed a commit to makssent/shardingsphere that referenced this pull request Jul 5, 2025
…5867)

* Fix the connection leak caused by rollback failure in Proxy

* Update RELEASE-NOTES.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In Proxy, if rollback fails when closing resources, it may cause connection leakage

2 participants