Implement write method in PostgreSQLBoolBinaryProtocolValue#35831
Merged
yx9o merged 2 commits intoapache:masterfrom Jun 28, 2025
Merged
Implement write method in PostgreSQLBoolBinaryProtocolValue#35831yx9o merged 2 commits intoapache:masterfrom
yx9o merged 2 commits intoapache:masterfrom
Conversation
yx9o
approved these changes
Jun 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #35830.
Test method:
Before
After
FAQ
Boolean.parseBoolean()method?Because
Boolean.parseBoolean()only matches the case where the string is "true", and the default bool output by PostgreSQL is a single character "t" or "f";If the output format is specified using
::TEXTor::INT, the type does not meet theBinarytype and will not be processed byPostgreSQLBoolBinaryProtocolValue.Therefore,
PostgreSQLBoolBinaryProtocolValueonly needs to process the cases of "t" or "f".