Skip to content

Add support for partition tables in Postgresql#34346

Merged
strongduanmu merged 1 commit intoapache:masterfrom
amirhmd:amirhmd_34329
Jan 17, 2025
Merged

Add support for partition tables in Postgresql#34346
strongduanmu merged 1 commit intoapache:masterfrom
amirhmd:amirhmd_34329

Conversation

@amirhmd
Copy link
Contributor

@amirhmd amirhmd commented Jan 13, 2025

Fixes #34329

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@amirhmd
Copy link
Contributor Author

amirhmd commented Jan 14, 2025

@strongduanmu I see Github Action is failing on fetching the repo. is there something I can do to fix the issue?

@strongduanmu
Copy link
Member

  • ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e

It seems to be a problem with the github action environment. We need to wait for github action to recover. Before that, you can execute ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e to make sure your code is OK.

@amirhmd
Copy link
Contributor Author

amirhmd commented Jan 14, 2025

result
^ all passed

@amirhmd
Copy link
Contributor Author

amirhmd commented Jan 14, 2025

@strongduanmu any chance to rerun the GHA workflow? Also, is this PR ready for review or should I check back later?

Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amirhmd, this pr looks great. Can you update RELEASE NOTE file?

@amirhmd
Copy link
Contributor Author

amirhmd commented Jan 15, 2025

Hi @strongduanmu release note updated

@taojintianxia taojintianxia modified the milestones: 5.5.2, 5.5.3 Jan 16, 2025
@amirhmd
Copy link
Contributor Author

amirhmd commented Jan 16, 2025

@strongduanmu any chance to get this pr reveiew again?

Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, merged. @amirhmd Thank you for your contribution.

@strongduanmu strongduanmu merged commit 07a5155 into apache:master Jan 17, 2025
147 checks passed
@amirhmd amirhmd deleted the amirhmd_34329 branch January 17, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for partition tables in Postgresql

3 participants