Support connecting to Firebird via jdbcUrl containing the absolute path to fdb#34335
Support connecting to Firebird via jdbcUrl containing the absolute path to fdb#34335strongduanmu merged 1 commit intoapache:masterfrom
Conversation
3efbe2a to
dcc6cc8
Compare
| assertDoesNotThrow(() -> parser.parse("jdbc:firebirdsql:xxxxxxxx", null, null)); | ||
| assertThrows(SQLNonTransientConnectionException.class, () -> parser.parse("jdbc:firebirdsql://localhost:c:/data/db/test.fdb", null, null)); |
There was a problem hiding this comment.
- According to some verification in https://github.com/FirebirdSQL/jaybird/blob/v6.0.0/src/test/org/firebirdsql/jdbc/FBDriverTest.java , it seems that the exception should not be thrown although a jdbcUrl like
jdbc:firebirdsql:xxxxxxxxdoes not make sense. - What do you think? @TedCraft
There was a problem hiding this comment.
According to the manual (https://github.com/FirebirdSQL/jaybird-manual/blob/master/src/docs/asciidoc/chapters/connection/connection.adoc#pure_java-type) the jdbcUrl format jdbc:firebirdsql:xxxxxxxxxxxx kinda makes sense, since it uses the legacy url format used in firebird. In this case, we just specify the database alias (or path) and the host and port are used by default (localhost:3050). But even though this url type is supported, according to the same manual, it is recommended to use the new url format.
There was a problem hiding this comment.
-
My understanding is that I should respect the behavior of the Firebird JDBC Driver's classes.
-
There seems to be only the LGPL LICENSE for the Firebird JDBC Driver, so I would assume that everyone who uses both shardingsphere and the Firebird JDBC Driver would be affected by the LGPL. Maven's
optionalproperty is enough to comply with the ASF's requirements when distributing. I think there is no problem with PR at the moment.
For #29052.
Changes proposed in this pull request:
jdbc:firebird://localhost:32783//var/lib/firebird/data/demo_ds_2.fdb.org.firebirdsql.jdbc:jaybird:5.0.6.java8not being distributed under the ASF license at [FEATURE] Would consider replacing mybatis with hibernate? gravitino#4352 (comment) .org.firebirdsql.jdbc:jaybird:6.0.0in unit tests of shardingsphere. We still need JDK8 to run unit tests.jdbc:firebirdsql:xxxxxxxxdoes not make sense.Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.