Issue 31437 with keyword query error mysql by Yash-cor · Pull Request #34163 · apache/shardingsphere

Yash-cor · 2024-12-26T10:09:08Z

Changes proposed in this pull request:

Added DuplicateCommonTableExpressionAliasException to support with keyword binding.
This Issue is solved by the update in Sql binder in PR - #34141
Added WithSegmentBinderTest
Added with clause test in SQLBinderIT

Before committing this PR, I'm sure that I have checked the following options:

My code follows the code of conduct of this project.
I have self-reviewed the commit code.
I have (or in comment I request) added corresponding labels for the pull request.
I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
I have made corresponding changes to the documentation.
I have added corresponding unit tests for my changes.
I have updated the Release Notes of the current development version. For more details, see Update Release Note

…y and resolved the CheckTableExist error during With keyword Query execution

…31437_WITH_KEYWORD_QUERY_ERROR_MYSQL

strongduanmu · 2024-12-26T11:02:12Z

Hi @Yash-cor, can you sync master branch, and add sql bind test case for with statement.

Yash-cor · 2024-12-27T04:22:16Z

Hi @Yash-cor, can you sync master branch, and add sql bind test case for with statement.

Yeah sure

RELEASE-NOTES.md

strongduanmu · 2024-12-30T01:24:04Z

...he/shardingsphere/infra/binder/engine/segment/dml/expression/type/SubquerySegmentBinder.java

-        return new SubquerySegment(segment.getStartIndex(), segment.getStopIndex(), boundSelectStatement, segment.getText());
+        SubquerySegment result = new SubquerySegment(segment.getStartIndex(), segment.getStopIndex(), boundSelectStatement, segment.getText());
+        selectBinderContext.getCommonTableExpressionsSegmentsUniqueAliases().forEach(each -> {
+            ShardingSpherePreconditions.checkNotContains(binderContext.getCommonTableExpressionsSegmentsUniqueAliases(), each, () -> new UniqueCommonTableExpressionException(each.toString()));


Does this check happen in MySQL? If yes, please provide MySQL test results.

I have changed the logic for UniqueCommonTableAlias check
This check happens in MySQL but in ShardingSphere this check was happening while the query is executed in MySQL database so I have added this check during the creation of Query Context.

...pache/shardingsphere/infra/binder/engine/segment/dml/from/type/SimpleTableSegmentBinder.java

...n/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/with/WithSegmentBinder.java

strongduanmu · 2024-12-30T01:25:40Z

.../java/org/apache/shardingsphere/infra/binder/engine/statement/SQLStatementBinderContext.java


    private final SQLStatement sqlStatement;

+    private final Set<CaseInsensitiveString> commonTableExpressionsSegmentsUniqueAliases = new HashSet<>();


Please use Collection<CaseInsensitiveString> to replace Set<CaseInsensitiveString>.

Besides, dou you think CaseInsensitiveSet is better?

Now I am using Collection<String> commonTableExpressionsSegmentsUniqueAliases = new CaseInsensitiveSet<>();

CaseInsensitiveSet will be better as it ease the overhead of creating the object in case of Set

.../binder/src/test/java/org/apache/shardingsphere/infra/binder/with/WithSegmentBinderTest.java

strongduanmu · 2024-12-30T01:27:56Z

...pache/shardingsphere/infra/exception/kernel/syntax/UniqueCommonTableExpressionException.java

+    private static final long serialVersionUID = -8206891094419297634L;
+
+    public UniqueCommonTableExpressionException(final String alias) {
+        super(XOpenSQLState.SYNTAX_ERROR, 500, "Not unique table/alias: '%s'", alias);


Is this exception consistent with the database?

If yes, please update the exception document.

Yes this Error is present in MySQL with MySQl error code 1066
and SQLState as 42000 so do I have to create this exception somewhere else

strongduanmu · 2024-12-30T01:28:09Z

...pache/shardingsphere/infra/exception/kernel/syntax/UniqueCommonTableExpressionException.java

+import org.apache.shardingsphere.infra.exception.core.external.sql.sqlstate.XOpenSQLState;
+import org.apache.shardingsphere.infra.exception.core.external.sql.type.kernel.category.SyntaxSQLException;
+
+public final class UniqueCommonTableExpressionException extends SyntaxSQLException {


Please add java doc for this class.

strongduanmu · 2024-12-30T01:29:50Z

...main/java/org/apache/shardingsphere/sql/parser/statement/mysql/dml/MySQLDeleteStatement.java


    private ReturningSegment returningSegment;

+    private WithSegment withSegment;


Can you provide the documentation for MySQL DELETE WITH ?

For this class, you change the SQL parsing result, you need to add SQL Parser IT test to ensure that we handle withSegment

Will make these changes once the logic for the CTE's Unique Alias Name is clear.

…R_MYSQL

…RROR_MYSQL' into ISSUE_31437_WITH_KEYWORD_QUERY_ERROR_MYSQL

…with a different PR.

…R_MYSQL

…RROR_MYSQL' into ISSUE_31437_WITH_KEYWORD_QUERY_ERROR_MYSQL

...ardingsphere/infra/exception/kernel/syntax/DuplicateCommonTableExpressionAliasException.java

test/it/binder/src/test/resources/sqls/dml/select.xml

…R_MYSQL

strongduanmu

Looks so great, thank you for your efforts on this PR, I believe the community will benefit from it.

Yash-cor added 8 commits December 24, 2024 15:03

Added the With Segment Binder which improves the working of With Quer…

8544d67

…y and resolved the CheckTableExist error during With keyword Query execution

Added the changes

1653664

Resolves Merge Conflicts

2029eaf

Merge

068962b

Added unique Alias Exception while using Common Table Expression

f973677

Fix Spotless error

027ea9f

Merge remote-tracking branch 'refs/remotes/origin/master' into ISSUE_…

6c8660a

…31437_WITH_KEYWORD_QUERY_ERROR_MYSQL

Added Release Notes

88a1300

Yash-cor added 5 commits December 27, 2024 18:05

Added SQL bind test case for WithSegmentBinder

e2e18ea

Added Release Notes

ab34b8e

Resolve Merge Conflict

6a2640c

Resolve Merge Conflict

2b0c960

Added Release Notes

52f639f

Yash-cor marked this pull request as draft December 27, 2024 12:49

Solved Spotless and Checkstyle error

949ff51

Yash-cor marked this pull request as ready for review December 27, 2024 13:38

Merge branch 'master' into ISSUE_31437_WITH_KEYWORD_QUERY_ERROR_MYSQL

a27ede2

strongduanmu added type: enhancement in: SQL bind labels Dec 30, 2024

strongduanmu added this to the 5.5.2 milestone Dec 30, 2024

strongduanmu requested changes Dec 30, 2024

View reviewed changes

Merge branch 'apache:master' into ISSUE_31437_WITH_KEYWORD_QUERY_ERRO…

893cea5

…R_MYSQL

Yash-cor marked this pull request as draft December 30, 2024 05:54

Yash-cor added 5 commits December 31, 2024 11:01

Changed the working for Unique Alias Name Exception handling for CTE's

7fbb92f

Update Release Notes

5023a65

Merge branch 'apache:master' into ISSUE_31437_WITH_KEYWORD_QUERY_ERRO…

c340ae3

…R_MYSQL

Changed Release Notes to resolve merge conflict

791c956

Merge remote-tracking branch 'origin/ISSUE_31437_WITH_KEYWORD_QUERY_E…

7a9cd89

…RROR_MYSQL' into ISSUE_31437_WITH_KEYWORD_QUERY_ERROR_MYSQL

Yash-cor added 6 commits December 31, 2024 11:39

Sync With Master Branch

ff11f5e

Removed the Changes for with Clause in DeleteStatement will raise it …

aa99360

…with a different PR.

Merge branch 'apache:master' into ISSUE_31437_WITH_KEYWORD_QUERY_ERRO…

03cc31d

…R_MYSQL

Added SQLBinderIT test case for with clause.

01f9e2f

Merge

30e3647

Merge remote-tracking branch 'origin/ISSUE_31437_WITH_KEYWORD_QUERY_E…

0e7a6f1

…RROR_MYSQL' into ISSUE_31437_WITH_KEYWORD_QUERY_ERROR_MYSQL

Yash-cor marked this pull request as ready for review January 2, 2025 09:43

Yash-cor requested a review from strongduanmu January 2, 2025 09:43

strongduanmu requested changes Jan 5, 2025

View reviewed changes

...ardingsphere/infra/exception/kernel/syntax/DuplicateCommonTableExpressionAliasException.java Show resolved Hide resolved

test/it/binder/src/test/resources/sqls/dml/select.xml Show resolved Hide resolved

Merge branch 'apache:master' into ISSUE_31437_WITH_KEYWORD_QUERY_ERRO…

d32b7d4

…R_MYSQL

Yash-cor marked this pull request as draft January 7, 2025 06:07

Yash-cor added 10 commits January 7, 2025 12:42

Updated documentation for the new Exception created

67df1d8

Added e2e test case for with clause in e2e\sql\resources\cases\dql

56147e3

Corrected e2e test case for with clause

58d2c21

Refactor to sync master branch

ce53b70

Updates for e2e test case failure

c77d035

Changes made in e2e test case for db and tbl

30e9acd

Merge branch 'apache:master' into ISSUE_31437_WITH_KEYWORD_QUERY_ERRO…

d9ea315

…R_MYSQL

Sync master branch

b9131f7

Changes in e2e test case

5acbb84

Merge branch 'apache:master' into ISSUE_31437_WITH_KEYWORD_QUERY_ERRO…

761355a

…R_MYSQL

Yash-cor marked this pull request as ready for review January 8, 2025 12:23

Yash-cor requested a review from strongduanmu January 8, 2025 12:23

strongduanmu approved these changes Jan 9, 2025

View reviewed changes

strongduanmu merged commit 5c6745e into apache:master Jan 9, 2025
147 checks passed

strongduanmu mentioned this pull request Jan 9, 2025

Revise pr#34163 and update release note #34288

Merged

7 tasks

terrymanu mentioned this pull request Sep 25, 2025

Significantly enhance SQL binding capability #36702

Closed

16 tasks


		private final SQLStatement sqlStatement;

		private final Set<CaseInsensitiveString> commonTableExpressionsSegmentsUniqueAliases = new HashSet<>();


		private ReturningSegment returningSegment;

		private WithSegment withSegment;

Conversation

Yash-cor commented Dec 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this pull request:

Uh oh!

strongduanmu commented Dec 26, 2024

Uh oh!

Yash-cor commented Dec 27, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

strongduanmu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Yash-cor commented Dec 26, 2024 •

edited

Loading