Added support for STRRIGHT alias in Doris (#31508)#33393
Added support for STRRIGHT alias in Doris (#31508)#33393strongduanmu merged 6 commits intoapache:masterfrom
Conversation
RIGHT is already implemented and supported by both MySQL and Doris - Added parsing suppor t for the `STRRIGHT` alias in Doris - Updated existing tests to reflect that `RIGHT` is also supported by Doris - Added STRRIGHT tests - Marked `// DORIS ADDED BEGIN|END` Doris-specific changes - Added as a `regularFunctionName` which is where `RIGHT` is
|
I will look at the test results again as 76b9007 was supposed to fix the failing test |
also removed MySQL as target for the alias
|
Looks like on the most current code Waiting for that full rebuild to finish and issuing a fresh commit |
|
All checks passed and it looks good, just did a merge with upstream to have it up to date. Checks will be redone but not expecting any issues there. Ready to be reviewed |
strongduanmu
left a comment
There was a problem hiding this comment.
Looks great, merged. @danigiri Thank you for your excellent code.
Continuing with Doris parsing support.
In this case
RIGHTis already implemented and supported by both MySQL and Doris so ammended the tests and addedSTRRIGHTsupport which is an alias in Doris.Continues to address #31508.
Changes proposed in this pull request:
STRRIGHTalias in DorisRIGHTis also supported by DorisSTRRIGHT-specific test// DORIS ADDED BEGIN|ENDDoris-specific changes, and fixed a typo in existing oneregularFunctionNamewhich is whereRIGHTis so no java changes should be neededSELECT STRRIGHT('foobarbar',4)in Doris 3.0.2 correctlyNext
get PR id to update release notesfinish compiling Doris v3 to test the query codemy local machine is not powerful enoughBefore committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.mvn spotless:apply -Pcheckmvn test -Dit.test=InternalDorisParserITinshardingsphere/parser/sql/dialect/doris(need to specify it.test)SELECT STRRIGHT('foobarbar',4)