Feature: [Connector-V2] Add HubSpot Source Connector structure (#10358)#10447
Feature: [Connector-V2] Add HubSpot Source Connector structure (#10358)#10447Suresh-Krishna-Kusuma wants to merge 16 commits intoapache:devfrom
Conversation
…e#10358) This PR introduces the initial implementation of the HubSpot Source Connector (Phase 1). It is implemented by extending the generic HttpSource to leverage existing HTTP capabilities. Changes: - Added connector-http-hubspot module. - Implemented HubSpotSource and HubSpotSourceFactory. - Added dynamic configuration logic to map object_type to API URLs. - Added documentation in docs/en/connector-v2/source/HubSpot.md.
Issue 1: Configuration conversion has type incompatibility riskLocation: Issue 2: Document naming does not follow project conventionsLocation: Issue 3: Missing required configuration file updatesLocation: Issue 4: Custom Parameter class not implementedLocation: Issue 6: Sensitive information may leak to logsLocation: Issue 7: Missing newline at end of fileLocation: Issue 8: Inconsistent changelog formatLocation: Issue 9: Completely lacking test coverageLocation: Entire Issue 10: Documentation missing critical usage instructionsLocation: |
|
Thank you for your contribution. Can you add e2e test cases |
|
|
||
| ## 2.3.13-SNAPSHOT | ||
|
|
||
| - Add HubSpot Source Connector No newline at end of file |
There was a problem hiding this comment.
Can you also contribute the sink connector
… Unit tests, Configs)
docs/en/connectors/source/Github.md
Outdated
| Hubspot { | ||
| url = "https://api.github.com/orgs/apache/repos" | ||
| access_token = "xxxx" | ||
| method = "GET" |
There was a problem hiding this comment.
Do you need to update Github.md?
|
Thank you for the contribution! This is a good starting point for the HubSpot connector. I found several critical issues that need to be addressed before this can be merged. 1. Invalid Default 2. Mismatch between Default Schema and E2E Test Expectations
3. E2E Test Network Configuration is Incorrect
4.
5. Dependency Scope in 6. Documentation Accuracy |
This PR introduces the initial implementation of the HubSpot Source Connector (Phase 1). It is implemented by extending the generic HttpSource to leverage existing HTTP capabilities.
Changes:
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
incompatible-changes.mdto describe the incompatibility caused by this PR.