-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories #10049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LiJie20190102
wants to merge
19
commits into
apache:dev
Choose a base branch
from
LiJie20190102:file-filter-parttern-10012
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,164
−100
Open
Changes from 6 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a5822ec
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
bbdd493
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
46a2787
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
2e352bc
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
f64eede
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
f1aff6e
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
0bd638d
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
b70136c
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
768c0be
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
75c81f2
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
3028d99
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
6d6995a
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
15e15e2
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
9928688
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
a589d60
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
d96a651
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
d375235
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
08fd273
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
d7b4aff
[Fix][FTP]Fix 'file_filterpattern' cannot filter directories
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -106,12 +106,12 @@ Whether to enable remote host verification for FTP data channels, default is `tr | |
|
|
||
| ### file_filter_pattern [string] | ||
|
|
||
| Filter pattern, which used for filtering files. | ||
| Filter pattern, which used for filtering files. If you only want to filter based on file names, simply write the regular file names; If you want to filter based on the file directory at the same time, the expression needs to start with `path`. | ||
|
|
||
| The pattern follows standard regular expressions. For details, please refer to https://en.wikipedia.org/wiki/Regular_expression. | ||
| There are some examples. | ||
|
|
||
| File Structure Example: | ||
| If the `path` is `/data/setunnel`, and the file structure example is: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
|
|
||
| ``` | ||
| /data/seatunnel/20241001/report.txt | ||
|
|
@@ -126,7 +126,7 @@ Matching Rules Example: | |
| **Example 1**: *Match all .txt files*,Regular Expression: | ||
|
|
||
| ``` | ||
| /data/seatunnel/20241001/.*\.txt | ||
| .*.txt | ||
| ``` | ||
|
|
||
| The result of this example matching is: | ||
|
|
@@ -138,7 +138,7 @@ The result of this example matching is: | |
| **Example 2**: *Match all file starting with abc*,Regular Expression: | ||
|
|
||
| ``` | ||
| /data/seatunnel/20241002/abc.* | ||
| abc.* | ||
| ``` | ||
|
|
||
| The result of this example matching is: | ||
|
|
@@ -147,8 +147,7 @@ The result of this example matching is: | |
| /data/seatunnel/20241007/abch202410.csv | ||
| /data/seatunnel/20241002/abcg202410.csv | ||
| ``` | ||
|
|
||
| **Example 3**: *Match all file starting with abc,And the fourth character is either h or g*, the Regular Expression: | ||
| **Example 3**: *Match all files starting with abc in folder 20241007,And the fourth character is either h or g*, the Regular Expression: | ||
|
|
||
| ``` | ||
| /data/seatunnel/20241007/abc[h,g].* | ||
|
|
@@ -163,7 +162,7 @@ The result of this example matching is: | |
| **Example 4**: *Match third level folders starting with 202410 and files ending with .csv*, the Regular Expression: | ||
|
|
||
| ``` | ||
| /data/seatunnel/202410\d*/.*\.csv | ||
| /data/seatunnel/202410\d*/.*.csv | ||
| ``` | ||
|
|
||
| The result of this example matching is: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -118,12 +118,12 @@ default `\n` | |
|
|
||
| ### file_filter_pattern [string] | ||
|
|
||
| Filter pattern, which used for filtering files. | ||
| Filter pattern, which used for filtering files. If you only want to filter based on file names, simply write the regular file names; If you want to filter based on the file directory at the same time, the expression needs to start with `path`. | ||
|
|
||
| The pattern follows standard regular expressions. For details, please refer to https://en.wikipedia.org/wiki/Regular_expression. | ||
| There are some examples. | ||
|
|
||
| File Structure Example: | ||
| If the `path` is `/data/setunnel`, and the file structure example is: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
| ``` | ||
| /data/seatunnel/20241001/report.txt | ||
| /data/seatunnel/20241007/abch202410.csv | ||
|
|
@@ -135,22 +135,22 @@ Matching Rules Example: | |
|
|
||
| **Example 1**: *Match all .txt files*,Regular Expression: | ||
| ``` | ||
| /data/seatunnel/20241001/.*\.txt | ||
| .*.txt | ||
| ``` | ||
| The result of this example matching is: | ||
| ``` | ||
| /data/seatunnel/20241001/report.txt | ||
| ``` | ||
| **Example 2**: *Match all file starting with abc*,Regular Expression: | ||
| ``` | ||
| /data/seatunnel/20241002/abc.* | ||
| abc.* | ||
| ``` | ||
| The result of this example matching is: | ||
| ``` | ||
| /data/seatunnel/20241007/abch202410.csv | ||
| /data/seatunnel/20241002/abcg202410.csv | ||
| ``` | ||
| **Example 3**: *Match all file starting with abc,And the fourth character is either h or g*, the Regular Expression: | ||
| **Example 3**: *Match all files starting with abc in folder 20241007,And the fourth character is either h or g*, the Regular Expression: | ||
| ``` | ||
| /data/seatunnel/20241007/abc[h,g].* | ||
| ``` | ||
|
|
@@ -160,7 +160,7 @@ The result of this example matching is: | |
| ``` | ||
| **Example 4**: *Match third level folders starting with 202410 and files ending with .csv*, the Regular Expression: | ||
| ``` | ||
| /data/seatunnel/202410\d*/.*\.csv | ||
| /data/seatunnel/202410\d*/.*.csv | ||
| ``` | ||
| The result of this example matching is: | ||
| ``` | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.