[ISSUE #2334] Polish the log and response remark when service not available #2335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervice not available
vongosling
changed the title
vongosling
reviewed
Oct 9, 2020
broker/src/main/java/org/apache/rocketmq/broker/processor/ReplyMessageProcessor.java
Outdated
Show resolved
Hide resolved
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #2335 +/- ##
=============================================
- Coverage 45.81% 45.60% -0.22%
+ Complexity 4298 4280 -18
=============================================
Files 547 547
Lines 35971 35971
Branches 4770 4770
=============================================
- Hits 16481 16404 -77
- Misses 17433 17505 +72
- Partials 2057 2062 +5 Continue to review full report at Codecov.
|
vongosling
approved these changes
Oct 12, 2020
| // Failed | ||
| case CREATE_MAPEDFILE_FAILED: | ||
| log.info("create mapped file failed, server is busy or broken."); | ||
| log.warn("create mapped file failed, server is busy or broken."); |
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
…ot available (apache#2335) * enhancement(response & log):polish the log and response remark when service not available * enhancement(response remark & log): make log and response remark better understand * chore(style): modify code style to pass CI tests
pulllock
pushed a commit
to pulllock/rocketmq
that referenced
this pull request
Oct 19, 2023
…ot available (apache#2335) * enhancement(response & log):polish the log and response remark when service not available * enhancement(response remark & log): make log and response remark better understand * chore(style): modify code style to pass CI tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Polish the log and response remark when service not available
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.